feat: add agent_with_prompt_builder super-component#440
Closed
feat: add agent_with_prompt_builder super-component#440
Conversation
As we've seen ChatPromptBuilder be paired with Agent for every use-case, a good opportunity for simplification is a super-component that encapsulates the two.
Pull Request Test Coverage Report for Build 22147904224Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
sjrl
reviewed
Feb 17, 2026
sjrl
reviewed
Feb 17, 2026
Contributor
|
A few other comments I have:
|
sjrl
reviewed
Feb 18, 2026
sjrl
reviewed
Feb 18, 2026
…de-chatpromptbuilder-capability-to-agent-component
This commit also comes with a more robust test suite, including a simple rag-pipeline test to ensure input sockets are properly set in this context.
Contributor
Author
|
Superseded by deepset-ai/haystack#10638. |
marc-mrt
deleted the
feature/bui-198-provide-chatpromptbuilder-capability-to-agent-component
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
n/a
Proposed Changes:
As we've seen ChatPromptBuilder be paired with Agent for every use-case on the Platform, a good opportunity for simplification would be a (super-)component that encapsulates the two.
This is an attempts at implementation with a super-component indeed, happy for general feedback on that take.
How did you test it?
Added unit tests, mainly to ensure good behavior of the super-component's input inference based on the template provided.
Notes for the reviewer
I've tried to be exhaustive but there is one thing that I still don't quite get, and would appreciate guidance on:
to_dictandfrom_dict. I saw for example on Haystack'sdocument_preprocessorhow they are defined, but not on themulti_file_converterand I'm not sure I understand why on or the other.Also - as it's my first contribution to Haystack (albeit experimental), any pointers as to unfollowed standards, code quality or misunderstandings of the framework are more than welcome!
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.